Skip to content

add dummy vision and text transformer config (assumed mcore to be false)#9699

Merged
yaoyu-33 merged 2 commits intoNVIDIA-NeMo:r2.0.0rc1from
rohitrango:rohit/sd_train_clip_bug
Jul 22, 2024
Merged

add dummy vision and text transformer config (assumed mcore to be false)#9699
yaoyu-33 merged 2 commits intoNVIDIA-NeMo:r2.0.0rc1from
rohitrango:rohit/sd_train_clip_bug

Conversation

@rohitrango
Copy link
Contributor

What does this PR do ?

Add parameters to CLIP model loading for SD training.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohitrango@users.noreply.github.com>
@rohitrango
Copy link
Contributor Author

@yaoyu-33

@yaoyu-33 yaoyu-33 merged commit d036c41 into NVIDIA-NeMo:r2.0.0rc1 Jul 22, 2024
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
…se) (#9699)

* add dummy vision and text transformer config (assumed mcore to be false)

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>

* Apply isort and black reformatting

Signed-off-by: rohitrango <rohitrango@users.noreply.github.com>

---------

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohitrango@users.noreply.github.com>
ericharper pushed a commit that referenced this pull request Jul 24, 2024
…se) (#9699) (#9827)

* add dummy vision and text transformer config (assumed mcore to be false)



* Apply isort and black reformatting



---------

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohitrango@users.noreply.github.com>
Co-authored-by: Rohit Jena <rohitrango@users.noreply.github.com>
tonyjie pushed a commit to tonyjie/NeMo that referenced this pull request Jul 24, 2024
…se) (NVIDIA-NeMo#9699) (NVIDIA-NeMo#9827)

* add dummy vision and text transformer config (assumed mcore to be false)



* Apply isort and black reformatting



---------

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohitrango@users.noreply.github.com>
Co-authored-by: Rohit Jena <rohitrango@users.noreply.github.com>
akoumpa pushed a commit that referenced this pull request Jul 25, 2024
…se) (#9699) (#9827)

* add dummy vision and text transformer config (assumed mcore to be false)

* Apply isort and black reformatting

---------

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohitrango@users.noreply.github.com>
Co-authored-by: Rohit Jena <rohitrango@users.noreply.github.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jul 30, 2024
…se) (NVIDIA-NeMo#9699) (NVIDIA-NeMo#9827)

* add dummy vision and text transformer config (assumed mcore to be false)

* Apply isort and black reformatting

---------

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohitrango@users.noreply.github.com>
Co-authored-by: Rohit Jena <rohitrango@users.noreply.github.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
xuanzic pushed a commit to xuanzic/NeMo that referenced this pull request Aug 1, 2024
…se) (NVIDIA-NeMo#9699) (NVIDIA-NeMo#9827)

* add dummy vision and text transformer config (assumed mcore to be false)

* Apply isort and black reformatting

---------

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohitrango@users.noreply.github.com>
Co-authored-by: Rohit Jena <rohitrango@users.noreply.github.com>
Signed-off-by: Vivian Chen <xuanzic@example.com>
kchike pushed a commit to kchike/NeMo that referenced this pull request Aug 8, 2024
…se) (NVIDIA-NeMo#9699) (NVIDIA-NeMo#9827)

* add dummy vision and text transformer config (assumed mcore to be false)

* Apply isort and black reformatting

---------

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohitrango@users.noreply.github.com>
Co-authored-by: Rohit Jena <rohitrango@users.noreply.github.com>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
…se) (#9699) (#9827)

* add dummy vision and text transformer config (assumed mcore to be false)



* Apply isort and black reformatting



---------

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohitrango@users.noreply.github.com>
Co-authored-by: Rohit Jena <rohitrango@users.noreply.github.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
…se) (NVIDIA-NeMo#9699) (NVIDIA-NeMo#9827)

* add dummy vision and text transformer config (assumed mcore to be false)



* Apply isort and black reformatting



---------

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohitrango@users.noreply.github.com>
Co-authored-by: Rohit Jena <rohitrango@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
…se) (NVIDIA-NeMo#9699) (NVIDIA-NeMo#9827)

* add dummy vision and text transformer config (assumed mcore to be false)



* Apply isort and black reformatting



---------

Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohitrango@users.noreply.github.com>
Co-authored-by: Rohit Jena <rohitrango@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments