Query TransformerConfig attributes when copying btw configs#9832
Merged
Query TransformerConfig attributes when copying btw configs#9832
Conversation
akoumpa
force-pushed
the
akoumparouli/update_set_model_parallel_attributes
branch
from
b6c99f9 to
2f21824
Compare
hemildesai
reviewed
Jul 22, 2024
akoumpa
force-pushed
the
akoumparouli/update_set_model_parallel_attributes
branch
3 times, most recently
from
2cb718f to
9aa075c
Compare
akoumpa
force-pushed
the
akoumparouli/update_set_model_parallel_attributes
branch
from
1d0da78 to
b2704d0
Compare
akoumpa
force-pushed
the
akoumparouli/update_set_model_parallel_attributes
branch
from
5e12a02 to
1cc8810
Compare
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa
force-pushed
the
akoumparouli/update_set_model_parallel_attributes
branch
from
1cc8810 to
6feaca4
Compare
akoumpa
force-pushed
the
akoumparouli/update_set_model_parallel_attributes
branch
3 times, most recently
from
d91a9f3 to
2370034
Compare
akoumpa
force-pushed
the
akoumparouli/update_set_model_parallel_attributes
branch
from
2370034 to
f4ac304
Compare
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
akoumpa
added a commit
that referenced
this pull request
Jul 25, 2024
* Query TransformerConfig attributes when copying btw configs Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * test Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jul 30, 2024
…eMo#9832) * Query TransformerConfig attributes when copying btw configs Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * test Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
xuanzic
pushed a commit
to xuanzic/NeMo
that referenced
this pull request
Aug 1, 2024
…eMo#9832) * Query TransformerConfig attributes when copying btw configs Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * test Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: Vivian Chen <xuanzic@example.com>
kchike
pushed a commit
to kchike/NeMo
that referenced
this pull request
Aug 8, 2024
…eMo#9832) * Query TransformerConfig attributes when copying btw configs Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * test Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Query TransformerConfig attributes when copying btw configs Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * test Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
…eMo#9832) * Query TransformerConfig attributes when copying btw configs Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * test Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
…eMo#9832) * Query TransformerConfig attributes when copying btw configs Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * test Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
When copying a TransformerConfig use dir to get attribute names, instead of copying manually.
improves-maintainability= we don't have to manually change anything if the def. of TransformerConfig changes.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information