Skip to content

Fix hf hub for 0.24+#9857

Merged
titu1994 merged 1 commit intomainfrom
cherry-pick-main-6ff5bce31eecefa42d49b2c81fc57b1e1533fa7f
Jul 24, 2024
Merged

Fix hf hub for 0.24+#9857
titu1994 merged 1 commit intomainfrom
cherry-pick-main-6ff5bce31eecefa42d49b2c81fc57b1e1533fa7f

Conversation

@github-actions
Copy link
Contributor

What does this PR do ?

Fix the deprecation of ModelFilter

Collection: [Core]

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

* Update Huggingface Hub support

Signed-off-by: smajumdar <titu1994@gmail.com>

* Update hf hub

Signed-off-by: smajumdar <titu1994@gmail.com>

* Update hf hub

Signed-off-by: smajumdar <titu1994@gmail.com>

* Apply isort and black reformatting

Signed-off-by: titu1994 <titu1994@users.noreply.github.com>

---------

Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: Somshubra Majumdar <titu1994@gmail.com>
Signed-off-by: titu1994 <titu1994@users.noreply.github.com>
@github-actions github-actions bot added cherry-pick core Changes to NeMo Core Run CICD labels Jul 23, 2024
@github-actions github-actions bot requested a review from titu1994 July 23, 2024 23:35
@titu1994 titu1994 merged commit 5726d49 into main Jul 24, 2024
@titu1994 titu1994 deleted the cherry-pick-main-6ff5bce31eecefa42d49b2c81fc57b1e1533fa7f branch July 24, 2024 12:11
akoumpa pushed a commit that referenced this pull request Jul 25, 2024
* Update Huggingface Hub support

* Update hf hub

* Update hf hub

* Apply isort and black reformatting

---------

Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: Somshubra Majumdar <titu1994@gmail.com>
Signed-off-by: titu1994 <titu1994@users.noreply.github.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jul 30, 2024
* Update Huggingface Hub support

* Update hf hub

* Update hf hub

* Apply isort and black reformatting

---------

Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: Somshubra Majumdar <titu1994@gmail.com>
Signed-off-by: titu1994 <titu1994@users.noreply.github.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
xuanzic pushed a commit to xuanzic/NeMo that referenced this pull request Aug 1, 2024
* Update Huggingface Hub support

* Update hf hub

* Update hf hub

* Apply isort and black reformatting

---------

Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: Somshubra Majumdar <titu1994@gmail.com>
Signed-off-by: titu1994 <titu1994@users.noreply.github.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Signed-off-by: Vivian Chen <xuanzic@example.com>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* Update Huggingface Hub support



* Update hf hub



* Update hf hub



* Apply isort and black reformatting



---------

Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: Somshubra Majumdar <titu1994@gmail.com>
Signed-off-by: titu1994 <titu1994@users.noreply.github.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* Update Huggingface Hub support



* Update hf hub



* Update hf hub



* Apply isort and black reformatting



---------

Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: Somshubra Majumdar <titu1994@gmail.com>
Signed-off-by: titu1994 <titu1994@users.noreply.github.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* Update Huggingface Hub support



* Update hf hub



* Update hf hub



* Apply isort and black reformatting



---------

Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: Somshubra Majumdar <titu1994@gmail.com>
Signed-off-by: titu1994 <titu1994@users.noreply.github.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments