Skip to content

fix: remove usage of vllm to get device uuid and instead use nvidia-m…#105

Merged
parthchadha merged 3 commits intomainfrom
pchadha/use-nvml-device-id
Apr 1, 2025
Merged

fix: remove usage of vllm to get device uuid and instead use nvidia-m…#105
parthchadha merged 3 commits intomainfrom
pchadha/use-nvml-device-id

Conversation

@parthchadha
Copy link
Copy Markdown
Contributor

@parthchadha parthchadha commented Mar 31, 2025

…l-py library to get device uuid

What does this PR do ?

Removes the use of vllm to get uuid and instead relies on nvidia-ml-py library (official nvml library) to get uuid information. This allows us to not make vllm a core dependency of reinforcer.

Issues

Closes #101

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@parthchadha parthchadha force-pushed the pchadha/use-nvml-device-id branch from 56f3763 to fa81f45 Compare March 31, 2025 23:55
…l-py library to get device uuid

Signed-off-by: Parth Chadha <pchadha@nvidia.com>
@parthchadha parthchadha force-pushed the pchadha/use-nvml-device-id branch from fa81f45 to 3fa9131 Compare March 31, 2025 23:56
@terrykong
Copy link
Copy Markdown
Collaborator

Closes #101

@parthchadha parthchadha merged commit fea4cc5 into main Apr 1, 2025
13 checks passed
@parthchadha parthchadha deleted the pchadha/use-nvml-device-id branch April 1, 2025 14:01
yfw pushed a commit that referenced this pull request Apr 2, 2025
#105)

Signed-off-by: Parth Chadha <pchadha@nvidia.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
KiddoZhu pushed a commit that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dependency of vLLM in hf_policy

3 participants