fix: remove usage of vllm to get device uuid and instead use nvidia-m…#105
Merged
parthchadha merged 3 commits intomainfrom Apr 1, 2025
Merged
fix: remove usage of vllm to get device uuid and instead use nvidia-m…#105parthchadha merged 3 commits intomainfrom
parthchadha merged 3 commits intomainfrom
Conversation
56f3763 to
fa81f45
Compare
…l-py library to get device uuid Signed-off-by: Parth Chadha <pchadha@nvidia.com>
fa81f45 to
3fa9131
Compare
Collaborator
|
Closes #101 |
SahilJain314
approved these changes
Apr 1, 2025
yfw
pushed a commit
that referenced
this pull request
Apr 2, 2025
#105) Signed-off-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
KiddoZhu
pushed a commit
that referenced
this pull request
May 6, 2025
#105) Signed-off-by: Parth Chadha <pchadha@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l-py library to get device uuid
What does this PR do ?
Removes the use of vllm to get
uuidand instead relies onnvidia-ml-pylibrary (officialnvmllibrary) to getuuidinformation. This allows us to not makevllma core dependency of reinforcer.Issues
Closes #101
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information