docs: End-to-end timeline view with nsys#1114
Conversation
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
WalkthroughAdded two identical documentation blocks to Changes
Sequence Diagram(s)Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Comment Pre-merge checks✅ Passed checks (3 passed)
|
terrykong
left a comment
There was a problem hiding this comment.
this is awesome @youngeunkwon0405
does this close #569 @guyueh1 ?
if so, @youngeunkwon0405 can you add "Closes #569" in the PR description since it only closes issues if that language is added to the description
|
@youngeunkwon0405 also can you add the figure to our docs, i think it's a helpful visual |
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
|
@terrykong Added the figure to the doc. The visualization in the doc will look like this.
For closing the issue #569, let me wait for @guyueh1 's confirmation. |
|
Also, was that unified profile created from an async run since the training and generation overlap? If so, did you also solve #922? |
Yes, the run is an async run. For the NVTX marker, we still need a fix. If you look at the profile screenshot, you can see that only the training side has the nvtx marker. |
|
#569 should be closed. The remained issue in 569 (verifying if nsys works for AsyncLLM) is followed-up in another issue. |
Hi @terrykong , can we merge this MR? For the #922, I am working on it from a different branch, since it is a different issue. |
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>

What does this PR do ?
This PR shows how to create a single timeline view of the End-to-end RL loop in the Nsight Systems.
The example figure is an LLaMa 3 8B Async GRPO run that the generation and the training are overlapped to each other.
FYI: @parthchadha @guyueh1
Issues
List issues that this PR closes (syntax):
CLOSES: #569
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit