docs: async doc update for importance sampling correction#1222
Merged
docs: async doc update for importance sampling correction#1222
Conversation
… correction is required for async convergence Signed-off-by: Parth Chadha <pchadha@nvidia.com>
Contributor
📝 WalkthroughWalkthroughAdds a new subsection to docs/guides/async-grpo.md explaining the need for importance sampling correction in asynchronous GRPO, detailing the objective, distribution mismatch from generator policies, and how the objective adjusts when use_importance_sampling_correction is enabled. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jgerh
reviewed
Sep 30, 2025
Contributor
jgerh
left a comment
There was a problem hiding this comment.
Completed tech pubs review and provided a few comments.
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Parth Chadha <parth29@gmail.com>
terrykong
approved these changes
Sep 30, 2025
PrinsYin
pushed a commit
to PrinsYin/RL
that referenced
this pull request
Nov 30, 2025
…o#1222) Signed-off-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: Parth Chadha <parth29@gmail.com> Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com>
yuanhangsu1986
pushed a commit
to yuanhangsu1986/RL-Nemontron-Edge-Omni
that referenced
this pull request
Feb 21, 2026
…o#1222) Signed-off-by: Parth Chadha <pchadha@nvidia.com> Signed-off-by: Parth Chadha <parth29@gmail.com> Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… correction is required for async convergence
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit