docs: add missing async_grpo.enabled flag to configuration#1237
docs: add missing async_grpo.enabled flag to configuration#1237terrykong merged 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
📝 WalkthroughWalkthroughAdds an enabled flag for Async GRPO in two YAML configuration sections within the Async GRPO guide: policy.async_grpo.enabled: true and grpo.async_grpo.enabled: true. No other modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @parthchadha, I guess the |
|
@CodeRabbit title |
|
Tip For best results, initiate chat on the files or code changes. @terrykong, the current PR title "fix: fix async grpo doc" could be more descriptive. Here are some suggestions for a clearer title: Recommended:
Alternative:
These titles:
Would you like me to update the PR title to one of these suggestions? |
…Mo#1237) Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
…Mo#1237) Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
…Mo#1237) Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit