Skip to content

fix: qwen30 config had typo in metric check#1266

Merged
terrykong merged 1 commit intomainfrom
tk/qwen30b-syntax
Oct 5, 2025
Merged

fix: qwen30 config had typo in metric check#1266
terrykong merged 1 commit intomainfrom
tk/qwen30b-syntax

Conversation

@terrykong
Copy link
Copy Markdown
Collaborator

@terrykong terrykong commented Oct 3, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Summary by CodeRabbit

  • Tests
    • Refined metric validation logic to compare a specific intermediate training step instead of the final step, improving consistency and reducing flaky failures in long-running validations.
    • Maintains overall pass/fail conditions while making per-step checks more reliable for automated test runs.
    • Enhances stability of CI for math-focused LLM training scenarios without impacting user-facing functionality.

Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong requested a review from chtruong814 October 3, 2025 06:31
@terrykong terrykong requested a review from a team as a code owner October 3, 2025 06:31
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 3, 2025

📝 Walkthrough

Walkthrough

Adjusts a per-step metrics index in a test script: the check now references data["train/token_mult_prob_error"]["3"] instead of using "$MAX_STEPS", while still verifying that the maximum step reached is at least MAX_STEPS.

Changes

Cohort / File(s) Summary of changes
Test suite script update
tests/test_suites/llm/grpo-math-qwen3-30ba3b-megatron-tp4-32k.sh
Changed per-step metric access from data["train/token_mult_prob_error"]["$MAX_STEPS"] to data["train/token_mult_prob_error"]["3"] within an existing conditional; overall control flow and error handling unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

CI:docs

Suggested reviewers

  • chtruong814
  • guyueh1

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Test Results For Major Changes ❓ Inconclusive
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit's high-level summary is enabled.
Title Check ✅ Passed The title explicitly states that a typo in the qwen30 configuration’s metric check was fixed, which directly matches the change of correcting the step index reference in the test config.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tk/qwen30b-syntax

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 557b7ec and 8bbb790.

📒 Files selected for processing (1)
  • tests/test_suites/llm/grpo-math-qwen3-30ba3b-megatron-tp4-32k.sh (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.sh

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.sh: Follow the Google Shell Style Guide for all shell scripts
Use uv run to execute Python scripts in shell/driver scripts instead of activating virtualenvs and calling python directly
Add the NVIDIA copyright header (with current year) at the top of all shell scripts, excluding tests/ and test-only scripts

Files:

  • tests/test_suites/llm/grpo-math-qwen3-30ba3b-megatron-tp4-32k.sh
tests/test_suites/llm/*.sh

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

LLM driver script filenames must mirror the YAML base name and follow the same pattern with .sh extension

Files:

  • tests/test_suites/llm/grpo-math-qwen3-30ba3b-megatron-tp4-32k.sh
tests/test_suites/**

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Place driver shell scripts and common.env under tests/test_suites// and list nightly tests in tests/test_suites/nightly.txt

Files:

  • tests/test_suites/llm/grpo-math-qwen3-30ba3b-megatron-tp4-32k.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Lint check
  • GitHub Check: Post submodule check comment / Comment on PR
  • GitHub Check: Post automodel integration comment / Comment on PR

Comment thread tests/test_suites/llm/grpo-math-qwen3-30ba3b-megatron-tp4-32k.sh
@terrykong terrykong added CI:docs Run doctest and removed CI:docs Run doctest labels Oct 5, 2025
@terrykong terrykong merged commit bf5445c into main Oct 5, 2025
62 of 69 checks passed
@terrykong terrykong deleted the tk/qwen30b-syntax branch October 5, 2025 06:35
PrinsYin pushed a commit to PrinsYin/RL that referenced this pull request Nov 30, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 21, 2026
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants