Skip to content

cp: fix: Fix checkpoint conversion error for qwen 30b-a3b (1335) into r0.4.0#1350

Merged
terrykong merged 1 commit intor0.4.0from
cherry-pick-1335-r0.4.0
Oct 14, 2025
Merged

cp: fix: Fix checkpoint conversion error for qwen 30b-a3b (1335) into r0.4.0#1350
terrykong merged 1 commit intor0.4.0from
cherry-pick-1335-r0.4.0

Conversation

@chtruong814
Copy link
Copy Markdown
Contributor

@chtruong814 chtruong814 commented Oct 13, 2025

beep boop [🤖]: Hi @yfw 👋,

we've cherry picked #1335 into  for you! 🚀

Please review and approve this cherry pick by your convenience!

Summary by CodeRabbit

  • Chores
    • Updated an internal third-party integration to the latest revision to stay aligned with upstream improvements. This is routine maintenance and does not introduce new features or change existing behavior.
    • No user-facing impact: performance, functionality, and UI remain the same.
    • No configuration changes required, and no action is needed from users.
    • Lays groundwork for future compatibility and smoother updates.

Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
@github-actions
Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 9e7771e (PR #1350 from cherry-pick-1335-r0.4.0)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of r0.4.0 branch (fast-forward)

All submodule changes look good! ✨

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 13, 2025

📝 Walkthrough

Walkthrough

Submodule pointer for 3rdparty/Megatron-Bridge-workspace/Megatron-Bridge updated from commit 9d69624cb75e46f06ddfadd9a726acecfcf8b064 to 62f4704b8d665ac4a8c318a809a070217caa8901. No changes to exported or public declarations in this repository.

Changes

Cohort / File(s) Change summary
Megatron-Bridge submodule update
3rdparty/Megatron-Bridge-workspace/Megatron-Bridge
Update submodule commit pointer: 9d69624c → 62f4704b

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

CI:L1, r0.4.0

Suggested reviewers

  • yaoyu-33
  • terrykong

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly indicates that this PR cherry-picks the checkpoint conversion error fix for qwen 30b-a3b into the r0.4.0 branch and directly reflects the main change without vague or unrelated content.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Test Results For Major Changes ✅ Passed The PR only advances the Megatron-Bridge submodule pointer to pick up an existing checkpoint conversion fix, with no direct source changes in this repository, which qualifies as a minor update; therefore the absence of explicit test results in the description is acceptable under the check criteria.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cherry-pick-1335-r0.4.0

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c62f36 and 9e7771e.

📒 Files selected for processing (1)
  • 3rdparty/Megatron-Bridge-workspace/Megatron-Bridge (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: CI quality check
  • GitHub Check: Lint check
  • GitHub Check: Post automodel integration comment / Comment on PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terrykong terrykong added the CI:L1 Run doctests, unit tests, and functional tests label Oct 13, 2025
@terrykong terrykong enabled auto-merge (squash) October 13, 2025 21:04
@terrykong terrykong merged commit 8ce81a0 into r0.4.0 Oct 14, 2025
82 of 88 checks passed
@terrykong terrykong deleted the cherry-pick-1335-r0.4.0 branch October 14, 2025 05:51
terrykong pushed a commit that referenced this pull request Nov 19, 2025
…to `r0.4.0` (#1350)

Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Yi-Fu Wu <yifu.wu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick CI:L1 Run doctests, unit tests, and functional tests Run CICD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants