docs: Create performance-summary.md for NeMo RL#1560
Conversation
📝 WalkthroughWalkthroughA new documentation file is added to provide benchmarking information for NVIDIA NeMo Framework's NeMo RL training. The document includes performance metrics nomenclature, summary structure, and placeholder tables with TODO items for future updates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/performance-summary.md(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-20T14:59:08.052Z
Learnt from: CR
Repo: NVIDIA-NeMo/RL PR: 0
File: coderabbit-custom-pre-merge-checks-unique-id-file-non-traceable-F7F2B60C-1728-4C9A-8889-4F2235E186CA.txt:0-0
Timestamp: 2025-09-20T14:59:08.052Z
Learning: If a change could affect performance, include before-and-after performance numbers in the PR description, along with configuration and context.
Applied to files:
docs/performance-summary.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build-container / main
- GitHub Check: Lint check
- GitHub Check: Post submodule check comment / Comment on PR
- GitHub Check: Post automodel integration comment / Comment on PR
🔇 Additional comments (2)
docs/performance-summary.md (2)
1-60: Add performance context to the PR description.Per learnings, when a change involves performance documentation or impacts performance, the PR description should include before-and-after performance numbers, along with configuration and context. This helps reviewers understand the significance of the changes and any performance implications.
Please update the PR description to include relevant performance context or benchmarking goals for this documentation.
54-57: The table structure is correctly aligned and will render properly.Verification shows all four rows (header, separator, and both data rows) contain exactly 19 pipes, which means 18 columns across the entire table. While the spacing around pipes is inconsistent for visual readability, the underlying table structure is sound and will parse correctly in Markdown. No fixes are required.
Likely an incorrect or invalid review comment.
terrykong
left a comment
There was a problem hiding this comment.
@snowmanwwg did you want to put this in the sidebar of our docs?
If so, you'll need to add this document into docs/index.md
Yes I want it to be an item in the side bar. How to add to index.md? |
ZhiyuLi-Nvidia
left a comment
There was a problem hiding this comment.
Added the formula for tokens/sec/GPU
|
Can we also replace MOE with MoE? I felt like the latter is more common. |
Co-authored-by: Guyue Huang <140554423+guyueh1@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Co-authored-by: Zhiyu Li <zhiyul@NVIDIA.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com>
ed374c3 to
3b89174
Compare
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: L.B. <llane@nvidia.com> Co-authored-by: Youngeun Kwon <youngeunk@nvidia.com> Co-authored-by: Guyue Huang <140554423+guyueh1@users.noreply.github.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: L.B. <llane@nvidia.com> Co-authored-by: Youngeun Kwon <youngeunk@nvidia.com> Co-authored-by: Guyue Huang <140554423+guyueh1@users.noreply.github.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Zhiyu Li <zhiyul@NVIDIA.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: L.B. <llane@nvidia.com> Co-authored-by: Youngeun Kwon <youngeunk@nvidia.com> Co-authored-by: Guyue Huang <140554423+guyueh1@users.noreply.github.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: L.B. <llane@nvidia.com> Co-authored-by: Youngeun Kwon <youngeunk@nvidia.com> Co-authored-by: Guyue Huang <140554423+guyueh1@users.noreply.github.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Zhiyu Li <zhiyul@NVIDIA.com>
Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: L.B. <llane@nvidia.com> Co-authored-by: Youngeun Kwon <youngeunk@nvidia.com> Co-authored-by: Guyue Huang <140554423+guyueh1@users.noreply.github.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Zhiyu Li <zhiyul@NVIDIA.com>

Added performance summary documentation for NeMo RL, including benchmarks, nomenclature, and performance metrics for large language models.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.