Conversation
Added documentation for model support and acceleration recipes. Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
This was referenced Jan 20, 2026
Closed
Contributor
📝 WalkthroughWalkthroughDocumentation build environment is refactored to use UV (uv) package manager exclusively instead of cross-platform virtual environment logic. A new documentation page describing Hugging Face model support via NeMo is introduced and integrated into the navigation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/about/model-support.md`:
- Around line 15-30: Standardize the Nemotron naming and YAML capitalization:
change the heading "NeMotron" to "Nemotron" and normalize variants to consistent
casing (e.g., "Llama-Nemotron-Super-49B", "Nemotron-nano-v2-12B" -> consider
"Nemotron-nano-v2-12B" vs "Nemotron-nano-v3-30A3B" but ensure all use "Nemotron"
with the same capitalization pattern), and replace the lowercase "yaml" with
"YAML" in the final sentence; update all occurrences of the strings "NeMotron",
"Nemotron-Nano", and "yaml" in this section to the standardized forms.
- Around line 3-13: The intro contains grammar and punctuation issues and a
sentence fragment: update the paragraph starting "NeMo-RL support 🤗Hugging Face
models..." and the following fragment "for model sizes under 70B at up to 32k
sequence length." into a single, grammatically correct sentence (e.g., "NeMo-RL
supports Hugging Face models from the following classes — LLMs
(AutoModelForCausalLM) and VLMs (AutoModelForImageTextToText) — for model sizes
under 70B and sequence lengths up to 32k."), fix spacing around
links/parentheses, ensure "supports" is used (not "support"), remove the
fragment, and normalize punctuation/spacing in the "NeMo Megatron-bridge"
heading paragraph so sentences are complete and links are punctuated
consistently.
yuki-97
approved these changes
Jan 21, 2026
chtruong814
pushed a commit
that referenced
this pull request
Jan 21, 2026
Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
yfw
pushed a commit
that referenced
this pull request
Feb 9, 2026
Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
yuanhangsu1986
pushed a commit
to yuanhangsu1986/RL-Nemontron-Edge-Omni
that referenced
this pull request
Feb 12, 2026
Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
yuanhangsu1986
pushed a commit
to yuanhangsu1986/RL-Nemontron-Edge-Omni
that referenced
this pull request
Feb 21, 2026
Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 8, 2026
Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 8, 2026
Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 9, 2026
Signed-off-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Wenwen Gao <94138584+snowmanwwg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
https://github.com/NVIDIA-NeMo/RL/pull/1706/changes
https://github.com/NVIDIA-NeMo/RL/pull/1705/changes
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.