Conversation
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
📝 WalkthroughWalkthroughConsolidates duplicated data setup logic from five example scripts (run_distillation_math.py, run_grpo.py, run_grpo_math.py, run_grpo_rm.py, run_vlm_grpo.py) into a centralized Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
examples/run_vlm_grpo.py (1)
93-100: Update stale comment about a “local” helper.Line 94 says the setup function is local, but it now comes from
nemo_rl.data.utils.✏️ Suggested rewording
- # this function is local to this script, and can be extended to other VLM datasets + # shared helper for VLM dataset/env setup (extend in nemo_rl.data.utils if needed)
🤖 Fix all issues with AI agents
In `@nemo_rl/data/utils.py`:
- Line 1: Update the file header year from 2025 to 2026: modify the top-of-file
copyright comment in nemo_rl/data/utils.py (the file header line starting with
"# Copyright (c)") so it reads 2026 to match repo header requirements.
- Around line 31-41: Add a Google-style docstring for the public function
setup_data_with_envs describing its purpose, parameters, return values, and
exceptions: include a short summary line, an Args section listing tokenizer
(AutoProcessor|AutoTokenizer), data_config (DataConfig), env_configs (dict[str,
Any]), and is_vlm (bool) with brief types and meanings, a Returns section
documenting the tuple (AllTaskProcessedDataset,
Optional[AllTaskProcessedDataset], dict[str, EnvironmentInterface], dict[str,
EnvironmentInterface]) and what each element represents, and an optional Raises
section for any exceptions that can be thrown; place this docstring immediately
under the def setup_data_with_envs(...) signature to satisfy the public API doc
guidelines.
Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
We use a same setup_data function in different
run_xxx.py, this PR move it tonemo_rl/data/utils.pyand reuse it.Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.