Skip to content

refactor: unify entrypoint for different envs#1841

Merged
terrykong merged 4 commits intomainfrom
yukih/unify-entrypoint
Feb 3, 2026
Merged

refactor: unify entrypoint for different envs#1841
terrykong merged 4 commits intomainfrom
yukih/unify-entrypoint

Conversation

@yuki-97
Copy link
Copy Markdown
Contributor

@yuki-97 yuki-97 commented Jan 29, 2026

After some dataset refactor work, we can load envs from configs instead of hardcoding in entrypoint now.

run_grpo_rm.py and run_grpo_math.py are exactly the same as run_grpo.py except the default config yaml.
This PR remove them and make env decoupled with entrypoint script.

Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97 yuki-97 requested review from a team as code owners January 29, 2026 06:18
@github-actions github-actions Bot added the Documentation Improvements or additions to documentation label Jan 29, 2026
@yuki-97 yuki-97 added the CI:L1 Run doctests, unit tests, and functional tests label Jan 29, 2026
@RayenTian
Copy link
Copy Markdown
Contributor

LGTM! Thanks for your hard work on PR prep.

Copy link
Copy Markdown
Collaborator

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work cleaning this up! always good to see more deletions than additions!

@terrykong terrykong merged commit 4b48248 into main Feb 3, 2026
41 of 42 checks passed
@terrykong terrykong deleted the yukih/unify-entrypoint branch February 3, 2026 02:09
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 12, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 21, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 21, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 9, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Aniketsy pushed a commit to Aniketsy/RL that referenced this pull request Mar 29, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Aniket Singh Yadav <singhyadavaniket43@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L1 Run doctests, unit tests, and functional tests Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants