Skip to content

docs: Fix a step time number for deepseek#1890

Merged
terrykong merged 1 commit intoNVIDIA-NeMo:mainfrom
guyueh1:fix_v0.5_perf_results
Feb 6, 2026
Merged

docs: Fix a step time number for deepseek#1890
terrykong merged 1 commit intoNVIDIA-NeMo:mainfrom
guyueh1:fix_v0.5_perf_results

Conversation

@guyueh1
Copy link
Copy Markdown
Contributor

@guyueh1 guyueh1 commented Feb 6, 2026

What does this PR do ?

Fix one step time result in perf table for v0.5.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Summary by CodeRabbit

  • Documentation
    • Fixed an incorrect performance metric value in the performance summary documentation to ensure data accuracy.

Signed-off-by: Guyue Huang <guyueh@nvidia.com>
@guyueh1 guyueh1 added the Documentation Improvements or additions to documentation label Feb 6, 2026
@guyueh1 guyueh1 requested a review from a team as a code owner February 6, 2026 00:31
@guyueh1 guyueh1 added the CI:L2 Run doctests, unit tests, functional tests, and convergence tests label Feb 6, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

A single-line data correction in a performance benchmark table fixes the DAPO DeepSeek V3 On policy row's Total Step time value from 974 to 458 and corrects the line's formatting to align with the table structure.

Changes

Cohort / File(s) Summary
Documentation & Benchmarking Table
docs/about/performance-summary.md
Corrected DAPO DeepSeek V3 On policy row: fixed Total Step time metric value from 974 to 458 and reformatted line to start with pipe character for proper table alignment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

CI:docs

Suggested reviewers

  • terrykong
  • snowmanwwg
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: fixing a step time number in documentation for deepseek, which directly matches the single data entry correction in the performance table.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed This PR is a minor documentation-only fix correcting a single metric value with no code modifications, features, or breaking changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terrykong terrykong added CI:docs Run doctest and removed CI:L2 Run doctests, unit tests, functional tests, and convergence tests labels Feb 6, 2026
@terrykong terrykong enabled auto-merge (squash) February 6, 2026 08:10
@terrykong terrykong merged commit 9dbd9ad into NVIDIA-NeMo:main Feb 6, 2026
71 checks passed
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 12, 2026
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 21, 2026
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 9, 2026
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Aniketsy pushed a commit to Aniketsy/RL that referenced this pull request Mar 29, 2026
Signed-off-by: Guyue Huang <guyueh@nvidia.com>
Signed-off-by: Aniket Singh Yadav <singhyadavaniket43@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:docs Run doctest Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants