Skip to content

build: Do not install decord on arm#2034

Merged
terrykong merged 1 commit intomainfrom
chtruong/fix-decord
Feb 27, 2026
Merged

build: Do not install decord on arm#2034
terrykong merged 1 commit intomainfrom
chtruong/fix-decord

Conversation

@chtruong814
Copy link
Copy Markdown
Contributor

@chtruong814 chtruong814 commented Feb 27, 2026

What does this PR do ?

Do not install decord on arm

decord is a recent dependency added as part of this below PR. However, it is not installable for arm.
#2016

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Summary by CodeRabbit

  • Chores
    • Optimized platform-specific dependency handling to improve installation compatibility across different system architectures.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 requested a review from a team as a code owner February 27, 2026 16:09
@chtruong814 chtruong814 added the CI:docs Run doctest label Feb 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a5f73db and 020286e.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml

📝 Walkthrough

Walkthrough

Updated the decord dependency in pyproject.toml to be platform-specific, restricting installation to x86_64 architectures only. This is a configuration change affecting dependency resolution without altering application logic.

Changes

Cohort / File(s) Summary
Dependency Configuration
pyproject.toml
Added platform machine condition to decord dependency, restricting it to x86_64 platforms only.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'build: Do not install decord on arm' accurately describes the main change: making decord installation platform-specific to exclude ARM architectures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed Single-line build configuration change making decord platform-specific; minor dependency adjustment without affecting core functionality.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chtruong/fix-decord

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terrykong terrykong merged commit 618c582 into main Feb 27, 2026
40 of 41 checks passed
@terrykong terrykong deleted the chtruong/fix-decord branch February 27, 2026 18:46
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 8, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
seonjinn pushed a commit that referenced this pull request Mar 9, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:docs Run doctest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants