feat: SFT convergence run changes#21
Merged
SahilJain314 merged 6 commits intomainfrom Mar 22, 2025
Merged
Conversation
parthchadha
reviewed
Mar 21, 2025
ashors1
reviewed
Mar 21, 2025
Contributor
|
@yfw could you actually update the sft config with the convergence config you're using? Right now, the config settings are pretty arbitrary. I think it would be better to use a tested config. |
Contributor
Author
Yes, updated |
yfw
changed the title
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
To compare with NeMo 2 default llama3-8b recipe:
```
uv run examples/run_sft.py --config=examples/configs/sft.yaml \
sft.max_num_steps=1168251 \
sft.val_period=-1 \
sft.val_global_batch_size=128 \
sft.val_micro_batch_size=1 \
sft.val_at_start=false \
checkpointing.enabled=false \
policy.model_name=meta-llama/Meta-Llama-3-8B \
policy.train_global_batch_size=128 \
policy.train_micro_batch_size=1 \
policy.max_total_sequence_length=2048 \
policy.optimizer.kwargs='{"lr": 5e-6, "betas": [0.9, 0.98], "eps": 1e-5, "weight_decay":0.1}' \
policy.scheduler='{"name": "torch.optim.lr_scheduler.LinearLR", "kwargs": {"start_factor": 0.0196078, "end_factor": 1.0, "total_iters": 50}}' \
data.dataset_name=squad \
data.max_input_seq_length=2048 \
cluster.gpus_per_node=8
```
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
SahilJain314
approved these changes
Mar 21, 2025
ashors1
approved these changes
Mar 21, 2025
parthchadha
approved these changes
Mar 21, 2025
KiddoZhu
pushed a commit
that referenced
this pull request
May 6, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Co-authored-by: Sahil Jain <48468750+SahilJain314@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Several changes for SFT convergence run:
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Checklist when contributing
Additional Information