Skip to content

fix: ci uses umask #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 3 commits into from
Apr 17, 2025
Merged

fix: ci uses umask #211

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b75a44
fix: ci uses umask and removes ci dir at start for fresh checkpoint
terrykong Apr 17, 2025
fb71ead
re-instance the forceful clean
terrykong Apr 17, 2025
09a8438
Revert "re-instance the forceful clean"
terrykong Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .github/workflows/_run_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,24 @@ jobs:
- name: Run unit tests
run: |
docker exec nemo_container_${{ github.run_id }} git config --global --add safe.directory /opt/reinforcer
docker exec nemo_container_${{ github.run_id }} bash -eux -o pipefail -c "${{ inputs.UNIT_TEST_SCRIPT }}"
docker exec nemo_container_${{ github.run_id }} bash -eux -o pipefail -c "
# This is needed since we create virtualenvs in the workspace, so this allows it to be cleaned up if necessary
umask 000
${{ inputs.UNIT_TEST_SCRIPT }}"

- name: Run doc tests
run: |
docker exec nemo_container_${{ github.run_id }} bash -eux -o pipefail -c "${{ inputs.DOC_TEST_SCRIPT }}"
docker exec nemo_container_${{ github.run_id }} bash -eux -o pipefail -c "
# This is needed since we create virtualenvs in the workspace, so this allows it to be cleaned up if necessary
umask 000
${{ inputs.DOC_TEST_SCRIPT }}"

- name: Run functional tests
run: |
docker exec nemo_container_${{ github.run_id }} bash -eux -o pipefail -c "${{ inputs.FUNCTIONAL_TEST_SCRIPT }}"
docker exec nemo_container_${{ github.run_id }} bash -eux -o pipefail -c "
# This is needed since we create virtualenvs in the workspace, so this allows it to be cleaned up if necessary
umask 000
${{ inputs.FUNCTIONAL_TEST_SCRIPT }}"

- uses: "NVIDIA/NeMo/.github/actions/cancel-workflow@main"
if: failure()
Expand Down