fix: fix make_sequence_length_divisible_by in config#2135
Conversation
Signed-off-by: Yuki Huang <yukih@nvidia.com>
a86bf79 to
91b561b
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughMultiple LLM training recipe configuration files were updated to adjust Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use your project's `ruff` configuration to improve the quality of Python code reviews.Add a Ruff configuration file to your project to customize how CodeRabbit runs |
|
/ok to test 91b561b |
#2053 makes megatron respect to
policy.make_sequence_length_divisible_by, but some configs are missing to update this param. This PR fixes it.Summary by CodeRabbit
Chores