fix: add Gym submodule to git safe.directory in CI#2186
Merged
Conversation
Fixes git ownership issue when building nemo-gym in CI containers. Since January 2026, the Gym submodule uses setuptools-scm which requires git access during package builds. In CI Docker containers, git blocks access due to ownership mismatch (security feature in Git 2.35.2+). This adds the Gym submodule directory to safe.directory, consistent with the existing pattern for the main repo. Resolves build failures in grpo_async_gym and other tests that build nemo-gym from the submodule. Co-Authored-By: Kajal Jain <kajalj@nvidia.com> Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Kajal Jain <kajalj@nvidia.com>
kajalj22
force-pushed
the
fix/gym-submodule-safe-directory
branch
from
88411d6 to
03b4fa0
Compare
Contributor
Author
|
/ok to test 03b4fa0 |
kajalj22
added
the
CI:Lfast
terrykong
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes git ownership issue when building
nemo-gymin CI containers for external contributors.Problem
Since January 2026 (PR #1773), the Gym submodule uses
setuptools-scmwhich requires git access during package builds. In CI Docker containers:fatal: detected dubious ownership in repository at '/opt/nemo-rl/3rdparty/Gym-workspace/Gym'Solution
Add the Gym submodule directory to git's
safe.directoryconfig, consistent with the existing pattern for the main repo (line 142).Risk Assessment
Low Risk:
Testing
https://github.com/NVIDIA-NeMo/RL/actions/runs/23680116283/job/68994254946
safe.directorypatternRelated Issues
Resolves build failures in functional tests that use nemo-gym.
🤖 Generated with Claude Code