Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ checkpointing:
policy:
model_name: Qwen/Qwen3-30B-A3B
train_micro_batch_size: 1
logprob_batch_size: 4
max_total_sequence_length: 4096
dtensor_cfg:
enabled: false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ checkpointing:
policy:
model_name: Qwen/Qwen3-30B-A3B
train_micro_batch_size: 1
logprob_batch_size: 4
max_total_sequence_length: 40960
dtensor_cfg:
enabled: false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ checkpointing:
policy:
model_name: Qwen/Qwen3-32B
train_micro_batch_size: 1
logprob_batch_size: 4
max_total_sequence_length: 4096
dtensor_cfg:
enabled: false
Expand Down
2 changes: 2 additions & 0 deletions tests/test_suites/llm/grpo-qwen3-30ba3b-8n8g-megatron.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/bin/bash
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd)
source $SCRIPT_DIR/common.env
# ignore tensor parallel accuracy check
export NRL_IGNORE_TP_ACCURACY_CHECK=1

# ===== BEGIN CONFIG =====
NUM_NODES=8
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
#!/bin/bash
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd)
source $SCRIPT_DIR/common.env
# ignore tensor parallel accuracy check
export NRL_IGNORE_TP_ACCURACY_CHECK=1

# ===== BEGIN CONFIG =====
NUM_NODES=4
STEPS_PER_RUN=10
STEPS_PER_RUN=5
MAX_STEPS=10
NUM_RUNS=$(( (MAX_STEPS + STEPS_PER_RUN - 1) / STEPS_PER_RUN )) # Round up
NUM_MINUTES=100
Expand All @@ -24,6 +26,7 @@ uv run examples/run_grpo.py \
logger.monitor_gpus=True \
logger.tensorboard_enabled=True \
checkpointing.enabled=True \
checkpointing.save_period=5 \
checkpointing.checkpoint_dir=$CKPT_DIR \
$@ \
2>&1 | tee $RUN_LOG
Expand Down
2 changes: 2 additions & 0 deletions tests/test_suites/llm/performance/grpo-qwen3-32b-4n8g.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/bin/bash
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd)
source $SCRIPT_DIR/common.env
# ignore tensor parallel accuracy check
export NRL_IGNORE_TP_ACCURACY_CHECK=1

# ===== BEGIN CONFIG =====
NUM_NODES=4
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/bin/bash
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd)
source $SCRIPT_DIR/common.env
# ignore tensor parallel accuracy check
export NRL_IGNORE_TP_ACCURACY_CHECK=1

# ===== BEGIN CONFIG =====
NUM_NODES=8
Expand Down
11 changes: 11 additions & 0 deletions tests/unit/test_config_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,17 @@ def test_all_config_no_tp_size_accuracy_issues(config_file):
Related document: https://docs.nvidia.com/nemo/rl/latest/guides/dtensor-tp-accuracy.html#root-cause.
"""

skip_config_files = [
"grpo-qwen3-30ba3b-4n8g-40K.yaml",
"grpo-qwen3-30ba3b-8n8g-megatron.yaml",
"grpo-qwen3-32b-4n8g.yaml",
"grpo-qwen3-32b-8n8g-async-1off.yaml",
]
if os.path.basename(config_file) in skip_config_files:
pytest.skip(
f"Skipping config file {config_file} because it sets NRL_IGNORE_TP_ACCURACY_CHECK=1"
)

print(f"\nValidating config file: {config_file}")

# Load the config file with inheritance
Expand Down
Loading