Skip to content

fix: skip vllm p2p check since its flaky #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthchadha merged 1 commit into from
Apr 21, 2025
Merged

fix: skip vllm p2p check since its flaky #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions nemo_reinforcer/models/generation/vllm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ def configure_worker(
init_kwargs["fraction_of_gpus"] = num_gpus

env_vars["VLLM_ENABLE_V1_MULTIPROCESSING"] = "0"
# Skip vllm P2P check and rely on driver to report peer to peer capability.
env_vars["VLLM_SKIP_P2P_CHECK"] = "1"

return resources, env_vars, init_kwargs

Expand Down