Skip to content

fix: updated stale cluster.md #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 2 commits into from
Mar 21, 2025
Merged

fix: updated stale cluster.md #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45473ea
fix: updated stale cluster.md
terrykong Mar 21, 2025
bf64acb
Merge branch 'main' into cluster-touchup
terrykong Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions docs/cluster.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ export UV_CACHE_DIR=/path/that/all/workers/can/access/uv_cache
# Run from the root of NeMo-Reinforcer repo
NUM_ACTOR_NODES=1 # Total nodes requested (head is colocated on ray-worker-0)

COMMAND="bash -c 'uv pip install -e .; uv run ./examples/run_grpo.py'" \
COMMAND="uv pip install -e .; uv run ./examples/run_grpo_math.py" \
RAY_DEDUP_LOGS=0 \
UV_CACHE_DIR=YOUR_UV_CACHE_DIR \
CONTAINER=YOUR_CONTAINER \
MOUNTS="$PWD:$PWD" \
sbatch \
--nodes=$((NUM_ACTOR_NODES + 1)) \
--nodes=${NUM_ACTOR_NODES} \
--account=YOUR_ACCOUNT \
--job-name=YOUR_JOBNAME \
--partition=YOUR_PARTITION \
Expand All @@ -52,6 +52,11 @@ tail -f 1980204-logs/ray-driver.log
```

### Interactive Launching

:::{tip}
A key advantage of running interactively on the head node is the ability to execute multiple multi-node jobs without needing to requeue in the SLURM job queue. This means during debugging sessions, you can avoid submitting a new `sbatch` command each time and instead debug and re-submit your Reinforcer job directly from the interactive session.
:::

To run interactively, launch the same command as the [Batched Job Submission](#batched-job-submission) except omit the `COMMAND` line:
```sh
# Run from the root of NeMo-Reinforcer repo
Expand All @@ -62,7 +67,7 @@ UV_CACHE_DIR=YOUR_UV_CACHE_DIR \
CONTAINER=YOUR_CONTAINER \
MOUNTS="$PWD:$PWD" \
sbatch \
--nodes=$((NUM_ACTOR_NODES + 1)) \
--nodes=${NUM_ACTOR_NODES} \
--account=YOUR_ACCOUNT \
--job-name=YOUR_JOBNAME \
--partition=YOUR_PARTITION \
Expand All @@ -81,9 +86,9 @@ bash 1980204-attach.sh
```
Now that you are on the head node, you can launch the command like so:
```sh
uv venv -p python3.12.9 .venv
uv venv .venv
uv pip install -e .
uv run ./examples/run_grpo.py
uv run ./examples/run_grpo_math.py
```

## Kubernetes
Expand Down
2 changes: 1 addition & 1 deletion ray.sub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#SBATCH --gres=gpu:8


set -eou pipefail
set -eoux pipefail

########################################################
# User defined variables
Expand Down