Conversation
github-actions
Bot
added
Documentation
terrykong
force-pushed
the
tk/jgerh/reinforcer-docs
branch
2 times, most recently
from
7125a27 to
3aba70c
Compare
terrykong
force-pushed
the
tk/jgerh/reinforcer-docs
branch
from
3aba70c to
ebb46c3
Compare
jgerh
reviewed
May 2, 2025
Contributor
jgerh
left a comment
jgerh
left a comment
There was a problem hiding this comment.
Completed review of files and provided a few copyedits and suggested text additions for intros.
jgerh
reviewed
May 2, 2025
Contributor
jgerh
left a comment
jgerh
left a comment
There was a problem hiding this comment.
Completed review of files and provided a few copyedits and suggested text additions for intros.
Signed-off-by: Terry Kong <terryk@nvidia.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
This reverts commit 043e186. Signed-off-by: Terry Kong <terryk@nvidia.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
terrykong
force-pushed
the
tk/jgerh/reinforcer-docs
branch
from
ab3bdc1 to
87aa887
Compare
jgerh
approved these changes
May 6, 2025
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jun 10, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: jgerh <163925524+jgerh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #168 (rebased)