feat: improve worker group args/kwargs#539
Merged
SahilJain314 merged 5 commits intomainfrom Jul 1, 2025
Merged
Conversation
yuki-97
added
CI:L1
yuki-97
force-pushed
the
yukih/worker-group-args
branch
from
0da5ef1 to
eef6d04
Compare
SahilJain314
suggested changes
Jun 26, 2025
Contributor
SahilJain314
left a comment
SahilJain314
left a comment
There was a problem hiding this comment.
How should we handle the fact that passing args will fail under certain circumstances? Can we assert fail the args or remove them entirely for now? (until we figure out what's going on)? I don't want people to run into this as a sharp edge.
…ers_sharded_data Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
yuki-97
force-pushed
the
yukih/worker-group-args
branch
from
eef6d04 to
1eab584
Compare
yuki-97
added
CI:L1
Signed-off-by: Yuki Huang <yukih@nvidia.com>
yuki-97
force-pushed
the
yukih/worker-group-args
branch
from
1eab584 to
347d02c
Compare
yuki-97
added
CI:L1
Signed-off-by: Yuki Huang <yukih@nvidia.com>
yuki-97
added
CI:L1
Contributor
Author
@SahilJain314 Added assert. Also add an issue #582 to trace ray stops respecting non-kwargs arguments. |
SahilJain314
approved these changes
Jun 30, 2025
Contributor
SahilJain314
left a comment
SahilJain314
left a comment
There was a problem hiding this comment.
assert fail LGTM for now. We can run the CI to make sure all instances are covered.
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 2, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com>
therealnaveenkamal
pushed a commit
to therealnaveenkamal/RL
that referenced
this pull request
Jul 7, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com>
YzjiaoNvd
pushed a commit
to YzjiaoNvd/NeMo-RL
that referenced
this pull request
Jul 14, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com>
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under some conditions, ray stops respecting non-kwargs arguments.
This PR supports passing args/kwargs in
run_all_workers_multiple_dataandrun_all_workers_sharded_data, so that we can pass through kwargs instead of passing an unclear paramdata.