Skip to content

feat: Add megatron to hf converter#555

Merged
terrykong merged 6 commits intomainfrom
ashors/community_export
Jun 28, 2025
Merged

feat: Add megatron to hf converter#555
terrykong merged 6 commits intomainfrom
ashors/community_export

Conversation

@ashors1
Copy link
Copy Markdown
Contributor

@ashors1 ashors1 commented Jun 25, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

ashors1 added 2 commits June 25, 2025 10:55
Signed-off-by: Anna Shors <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
@github-actions github-actions Bot added the Documentation Improvements or additions to documentation label Jun 25, 2025
Copy link
Copy Markdown
Collaborator

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition!

i have a feeling these converters will be quite brittle. do you think we can do some kind of functional test that helps us validate this diamond:

graph LR
  HF1[HF qwen] --> MCORE[mcore qwen]
  MCORE --> HF2[HF qwen]
  HF1 --> DCP[DCP qwen]
  DCP --> HF2
Loading

Comment thread nemo_rl/models/megatron/community_import.py Outdated
ashors1 added 3 commits June 26, 2025 15:09
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
@terrykong
Copy link
Copy Markdown
Collaborator

terrykong commented Jun 27, 2025

can you add a comment in the nemo submodule why you set the PP=1 in the submodule's commit? it'll help us when we need to port the changes over to nemo.tron's replacement?

Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
Copy link
Copy Markdown
Contributor Author

ashors1 commented Jun 27, 2025

can you add a comment in the nemo submodule why you set the PP=1 in the submodule's commit? it'll help us when we need to port the changes over to nemo.tron's replacement?

Yep, done

@terrykong terrykong added this pull request to the merge queue Jun 27, 2025
Merged via the queue into main with commit acbfa65 Jun 28, 2025
12 of 14 checks passed
@terrykong terrykong deleted the ashors/community_export branch June 28, 2025 06:56
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jun 28, 2025
Signed-off-by: Anna Shors <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jun 30, 2025
Signed-off-by: Anna Shors <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jun 30, 2025
Signed-off-by: Anna Shors <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Xuehan <xxman@google.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jun 30, 2025
Signed-off-by: Anna Shors <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Xuehan <xxman@google.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 2, 2025
Signed-off-by: Anna Shors <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Xuehan <xxman@google.com>
therealnaveenkamal pushed a commit to therealnaveenkamal/RL that referenced this pull request Jul 7, 2025
Signed-off-by: Anna Shors <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
YzjiaoNvd pushed a commit to YzjiaoNvd/NeMo-RL that referenced this pull request Jul 14, 2025
Signed-off-by: Anna Shors <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
KiddoZhu pushed a commit that referenced this pull request Jul 28, 2025
Signed-off-by: Anna Shors <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
Signed-off-by: Anna Shors <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants