Skip to content

fix: fix mcore LR increment #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 1 commit into from
Jul 17, 2025
Merged

fix: fix mcore LR increment #685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion nemo_rl/models/policy/megatron_policy_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,9 @@ def train(

if not eval_mode:
# take one LR step every rollout batch
self.scheduler.step(increment=1)
# we need to scale the step by gbs to counteract the fact that NeMo automatically
# scales lr_warmup_steps by gbs during init
self.scheduler.step(increment=gbs)

# Aggregate metrics across all microbatches
mb_metrics = defaultdict(list)
Expand Down
Loading