Skip to content

feat(logger.py): support swanlab#691

Closed
tpoisonooo wants to merge 3 commits intoNVIDIA-NeMo:mainfrom
tpoisonooo:patch-5
Closed

feat(logger.py): support swanlab#691
tpoisonooo wants to merge 3 commits intoNVIDIA-NeMo:mainfrom
tpoisonooo:patch-5

Conversation

@tpoisonooo
Copy link
Copy Markdown
Contributor

@tpoisonooo tpoisonooo commented Jul 18, 2025

What does this PR do ?

wandb is unreachable for our district, add swanlab by instead. Just like github --> gitee

Issues

List issues that this PR closes (syntax):

No

Usage

  • You can potentially add a usage example below

Here is my example config:

logger:
  log_dir: "logs"  # Base directory for all logs
  num_val_samples_to_print: 0 # Number of validation samples to pretty print on terminal
  wandb_enabled: false
  swanlab_enabled: true
  tensorboard_enabled: true
  monitor_gpus: false  # If true, will monitor GPU usage and log to wandb and/or tensorboard
  wandb:
    project: "grpo-dev"
    name: "sj_megatron_1B"
  swanlab:
    project: "grpo-dev"
    name: "sj_megatron_1B"

Here is swanlab UI and public project

image
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: tpoisonooo <khj.application@aliyun.com>
Signed-off-by: tpoisonooo <khj.application@aliyun.com>
@github-actions github-actions Bot added the Documentation Improvements or additions to documentation label Jul 18, 2025
Signed-off-by: tpoisonooo <khj.application@aliyun.com>
@terrykong
Copy link
Copy Markdown
Collaborator

Hi @tpoisonooo . Thanks for submitting an initial PR. I'm not too familiar with this logger, could you share a little about it and how it compares to the existing loggers?

Also, as far as what changes/tests you need to add, please refer to this PR for how mlflow was added.

#697

@tpoisonooo
Copy link
Copy Markdown
Contributor Author

Hi @tpoisonooo . Thanks for submitting an initial PR. I'm not too familiar with this logger, could you share a little about it and how it compares to the existing loggers?

Also, as far as what changes/tests you need to add, please refer to this PR for how mlflow was added.

#697

about swanlab

As I know, https://github.com/SwanHubX/SwanLab is a company that operates in Zhongguancun, Beijing, and its functions are the same as those of wandb: collecting training logs and displaying them.

It currently supports Web, WeChat public accounts, Android, and iOS.

I chose Swanlab because https://wandb.ai/ was blocked in China two months ago.

@terrykong
Copy link
Copy Markdown
Collaborator

I chose Swanlab because https://wandb.ai/ was blocked in China two months ago.

Understood. Thanks for explaining. We would be grateful for the contribution. Feel free to refer to that mlflow PR for what you need to change to make sure this logger is a first class citizen. Feel free to ask any questions!

@tpoisonooo tpoisonooo mentioned this pull request Jul 23, 2025
4 tasks
@tpoisonooo tpoisonooo closed this Jul 23, 2025
@tpoisonooo
Copy link
Copy Markdown
Contributor Author

I opened a new PR, so close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants