Skip to content

fix: unit test error when coverage wasn't specified #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 1 commit into from
Mar 26, 2025
Merged

fix: unit test error when coverage wasn't specified #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/unit/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class UnitTestData(TypedDict):
start_time: str
metrics: dict
gpu_types: list[str]
coverage: dict
coverage: str


def pytest_sessionstart(session):
Expand Down Expand Up @@ -83,7 +83,7 @@ def pytest_sessionstart(session):
start_time=datetime.now().strftime("%Y-%m-%d %H:%M:%S"),
metrics={},
gpu_types=[],
coverage={},
coverage="[n/a] run with --cov=nemo_reinforcer",
)


Expand Down Expand Up @@ -122,10 +122,16 @@ def session_data(request, init_ray_cluster):
############################################################
# We directly access the coverage controller from the plugin manager
# so we can access the coverage total before the pytest session finishes.
cov_controller = None
if request.config.pluginmanager.hasplugin("_cov"):
plugin = request.config.pluginmanager.getplugin("_cov")
if plugin.cov_controller:
cov_controller = plugin.cov_controller

if not cov_controller:
# Means the user didn't run with --cov=...
return

# We currently don't use the cov_report since we can always access the coverage.json later, but
# in the future if we want to report the coverage more granularly as part of the session finish,
# we can access it here.
Expand Down