Merged
Conversation
c8aad08 to
a1ef1d2
Compare
parthchadha
previously approved these changes
Aug 26, 2025
Contributor
parthchadha
left a comment
There was a problem hiding this comment.
LGTM! @terrykong can you review as well
7ea9787 to
eea8706
Compare
jveronvialard
requested changes
Sep 2, 2025
2a13777 to
a495eaa
Compare
auto-merge was automatically disabled
September 17, 2025 16:45
Pull Request is not mergeable
This was referenced Sep 19, 2025
4 tasks
This was referenced Nov 4, 2025
This was referenced Dec 15, 2025
This was referenced Feb 4, 2026
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
load_response_dataset,load_preference_datasetAPIs.ResponseDatasetfor SFT and RL.BinaryPreferenceDatasetandPreferenceDatasetfor DPO and RM.data_clswhich is duplicated withdataset_name. The logic will become below after this PR:dataset_nameis a built-in dataset, we'll use that dataset class as before.dataset_nameis in ["ResponseDataset", "BinaryPreferenceDataset", "PreferenceDataset"], we'll load data from local or Hugging Face throughtrain_data_pathandval_data_path.Issues
Related #909.
Usage
ResponseDataset:PreferenceDataset:BinaryPreferenceDataset:Test Result
Run well on below configs and some other configs.
convergence test with llama8b
sft-llama3.2-1b-1n8g-fsdp2tp1.v3
dpo-llama3.2-1b-instruct-1n8g-fsdp2tp1.v2
grpo-deepscaler-1.5b-8K
vlm_grpo-qwen2.5-vl-3b-instruct-clevr-1n2g-dtensor2tp1.v1
Summary by CodeRabbit
New Features
Documentation
Refactor
Tests