This repository was archived by the owner on Jan 7, 2025. It is now read-only.
Fixed broken image serving in development server#202
Closed
crohkohl wants to merge 1 commit intoNVIDIA:masterfrom
Closed
Fixed broken image serving in development server#202crohkohl wants to merge 1 commit intoNVIDIA:masterfrom
crohkohl wants to merge 1 commit intoNVIDIA:masterfrom
Conversation
Member
|
Thanks for the fix! Looks like I was working too hard. Can we go ahead and use Also, watch your extra whitespace on line 246. |
Merged
Author
|
|
Member
|
I can't push commits to your jobs_dir = config_value('jobs_dir')
return flask.send_from_directory(jobs_dir, path) |
0e134b1 to
2bf49c7
Compare
Author
|
okay, I put in your suggested change and squashed the two commits |
Member
|
I fixed the docs merged this into Thanks for the contribution! |
Author
|
great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separation of changes in separate pull request: #199
On my machine the image serving, e.g. of the mean.jpg does not work.
The browser (tested IE and Chrome) cannot interpret the image probably due to the missing content type. The send_file function takes care of that all.