Skip to content

Fix benchmark#100

Merged
zasdfgbnm merged 3 commits intomainfrom
fix-benchmark
Mar 30, 2023
Merged

Fix benchmark#100
zasdfgbnm merged 3 commits intomainfrom
fix-benchmark

Conversation

@zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Mar 30, 2023

Fixes #96

@zasdfgbnm zasdfgbnm requested a review from liqiangxl March 30, 2023 01:37
@naoyam
Copy link
Collaborator

naoyam commented Mar 30, 2023

Why did it cause the error message? Can we detect the error and give a better error message?

@zasdfgbnm
Copy link
Collaborator Author

Why did it cause the error message? Can we detect the error and give a better error message?

When the inputs is given to compileFusion, it will try to infer launch parameters and will try to compute shared memory usage. However, the fusion is scheduled like split(i, blockDim.x), which can not be infered without the launch constraints.

Copy link
Collaborator

@naoyam naoyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though still unclear why this was working.

@zasdfgbnm zasdfgbnm merged commit 3b3356b into main Mar 30, 2023
@zasdfgbnm zasdfgbnm deleted the fix-benchmark branch March 30, 2023 02:37
@naoyam
Copy link
Collaborator

naoyam commented Mar 30, 2023

Looks like those benchmarks are not the only ones that do compileFusion a scheduled fusion without passing launch constraints.

@liqiangxl
Copy link
Collaborator

here is another one, #102
after this, all the benchmarks work fine.

@naoyam
Copy link
Collaborator

naoyam commented Mar 30, 2023

Thanks @liqiangxl. Could you please do a quick check to find where this started to happen? I wonder if my PR of cleaning up index types might be the reason, but I'm pretty sure I ran all the benchmarks. Looking at the recent merged PRs, I don't see anything particularly suspicious.

@liqiangxl
Copy link
Collaborator

It failed at least on the initial commit of this new Fuser repo. Let me check the old one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

benchmark case failed

3 participants