Merged
Conversation
…to more-expr-simplification
naoyam
reviewed
Mar 31, 2023
csrc/predicate_compute.cpp
Outdated
| GpuLower::current()->caMap()->getConcreteMappedID( | ||
| pred_id, IdMappingMode::EXACT)); | ||
| auto new_pred = SimplifyingIrBuilder::ltExpr(index, pred_id->extent()); | ||
| // pt_ not being exact does not mean the predicate is not trivial. For |
Collaborator
There was a problem hiding this comment.
This makes sense, but wouldn't it be nicer if such IDs were not added to the predicate ID list from the beginning? Can this filtering be done at around line 211?
Collaborator
Author
There was a problem hiding this comment.
I agree with what you said. Let me give it a try.
Collaborator
Author
There was a problem hiding this comment.
fixed, it's working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is stacked on #105, it fixes #95.
There are mainly two changes effective:
lower_scalar_hoist.cpp, add assumptions about parallel indicespredicate_compute.cpp, check if extent is the same as parallel dimensionOnly one of the above changes is sufficient to fix the bug, but I did both to be double safe.
cc: @mmigdal-nv @drzejan2