Staged replacement of the use of evaluate* and get* with evaluate() and value() [4/N]#1164
Merged
Staged replacement of the use of evaluate* and get* with evaluate() and value() [4/N]#1164
Conversation
Collaborator
Author
|
!build |
protonu
force-pushed
the
use_polymorphic_vals_4
branch
4 times, most recently
from
262d08d to
48467f9
Compare
…nd value() [4/4] Final of this stack and removes the old APIs.
protonu
force-pushed
the
use_polymorphic_vals_4
branch
from
48467f9 to
cfdeeec
Compare
Collaborator
Author
|
!build |
zasdfgbnm
approved these changes
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces uses of evaluate(Int, Bool, Double) with evaluate which returns a PolymorphicValue.
This also replaces the uses of get(Int, Bool, Double) with value().
This PR is the fourth and final one of them to fix the issue. In the final PR, the older get* and evaluate* methods will be removed.
Fixes #643