Conversation
Collaborator
Author
|
!build |
This is separated from #1281 to keep the PR small.
zasdfgbnm
reviewed
Nov 13, 2023
| std::pair<V, typename LinkedHashMap<K, V>::const_iterator> LinkedHashMap<K, V>:: | ||
| erase(const K& key) { | ||
| const_iterator index = key_to_index_.at(key); | ||
| return {index->second, order_.erase(index)}; |
Collaborator
There was a problem hiding this comment.
Should we also erase from key_to_index_?
Collaborator
Author
There was a problem hiding this comment.
Fixed! Thanks for catching that.
zasdfgbnm
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is separated from #1281 to keep the PR small.