Unify IterDomain::split with SplitTransform and similar for merge#1329
Merged
jacobhinkle merged 11 commits intomainfrom Nov 20, 2023
Merged
Unify IterDomain::split with SplitTransform and similar for merge#1329jacobhinkle merged 11 commits intomainfrom
IterDomain::split with SplitTransform and similar for merge#1329jacobhinkle merged 11 commits intomainfrom
Conversation
Collaborator
Author
|
!build |
wujingyue
approved these changes
Nov 17, 2023
Co-authored-by: Jingyue Wu <wujingyue@gmail.com>
Co-authored-by: Jingyue Wu <wujingyue@gmail.com>
Collaborator
Author
|
!build --diff |
Collaborator
Author
|
!build --diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
MergeTransformandSplitTransform, which are the classes used to perform reshape operations, do not re-use the splitting and merging operations used in scheduling, namely the static methodsIterDomain::{split,merge}. This leads to needing to maintain changes in both as I recently found out when debugging #1174. We can actually already notice they have diverged with respect toIndexType::GatherScatterhandling.This PR simply calls the static
IterDomainmethod from each of the reshape*Transformclasses. Since those classes also need to set the rfactor-product flag on the producedIterDomains, I added a flag to the static methods that is only used during reshape.