s/DependencyCheck::getAllExprsBetween/StmtSort::getExprsBetween#1413
s/DependencyCheck::getAllExprsBetween/StmtSort::getExprsBetween#1413
Conversation
|
!build |
abc862c to
1e2480e
Compare
|
!build |
naoyam
left a comment
There was a problem hiding this comment.
Looks like the main change is actually removal of a Fusion parameter from the traverse functions of IterVisitor. I think that's fine as I don't think of any case where we would have a different Fusion than the Fusion where a given Statement is contained.
@zasdfgbnm Any concern?
|
!build --diff --diff-bench |
|
I don't see any use case where we want to use a different fusion either. |
naoyam
left a comment
There was a problem hiding this comment.
LGTM. Could you make sure the codegen diffs don't look anything suspicious? Since the PR changes the sorting API, it's expected that some expressions and variables may be ordered differently, but I don't expect no other change should happen.
|
!build --diff --diff-bench |
The only codegen diff is in integer multiplication order, which is fine. (I'd worry more about floating point multiplication order). |
Partially rolls forward #1413.
Partially rolls forward #1413.
Per #1295 (comment).