Fix a bug related to expanded broadcast IterDomains.#1489
Conversation
|
!build |
d45458d to
805d917
Compare
jacobhinkle
left a comment
There was a problem hiding this comment.
A bit more explanation would be much appreciated. As I understand it, this applies when the input of a ViewOp has an allocation domain that is a permutation of its rfactor. The input's allocation domain is used to determine the contiguity of the output at its root domain (as opposed to .contiguity() which refers to out's allocation domain). That is then propagated from root to rfactor to check if we require a copy. The change seems reasonable to me but it's not clear to me yet how this fails currently.
Your understanding described above is all correct. The code currently fails because due to #1126 (or a similar issue that your #1174 is trying to fix) nvFuser doesn't propagate the has-expanded-extent flag from |
|
!build |
My #1295 changed some tests in the wrong way so this bug has been hidden since then.