Conversation
Collaborator
Author
|
!build |
jjsjann123
approved these changes
Dec 11, 2023
| at::Tensor out_tensor = out_tensors[0]; | ||
| testValidate(fec.fusion(), {out_tensor}, {in_tensor}, __LINE__, __FILE__); | ||
|
|
||
| EXPECT_TRUE(out_tensor.is_alias_of(in_tensor)); |
Collaborator
There was a problem hiding this comment.
Nice!
cc'ing @kevinstephano since you were asking about support like this earlier.
Collaborator
Author
|
!build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
MarkAliasPassskips an output when its allocation domain is set at all. This PR makes it smarter to check compliance.This PR prepares #1478 for landing. Before segmentation, we'll run alias analysis on the un-segmented fusion and mark layouts for aliasing. During scheduling, we'll run alias analysis again on segmented fusions and have to recognize the preferred layout is compliant with the previously marked layout.