Factor out code that maps input layout to output root.#1587
Merged
Conversation
…ayout. This PR also comes with a refactor to `mergeContiguity` so `handle(ViewOp)` can use `mapInLayoutToOutRoot`. I can split that out if you find it hard to review.
Collaborator
Author
|
!build |
wujingyue
commented
Jan 5, 2024
| } | ||
| for (const auto i : c10::irange(out_root_layout->size())) { | ||
| allocation_to_contiguity.pushBack( | ||
| in_allocation_id, in_layout.contiguity[i]); |
Collaborator
Author
There was a problem hiding this comment.
Context: to work around #1174, allocation_to_contiguity may contain IterDomains both from the input TV and from the output. This however is unnecessary. The new code only puts output IterDomains in allocation_to_contiguity and looks up out_root_to_in_rfactor for expanded extents. It has the equivalent behavior but is more intuitive and doesn't need the in_rfactor_to_out_root map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1584 (comment).
This also comes with a refactor to
mergeContiguitysohandle(ViewOp)can usemapInLayoutToOutRoot. I can split that out if you find it hard to review.