Conversation
Collaborator
Author
|
!build |
naoyam
reviewed
Apr 17, 2023
| //! higher than provided major.minor. | ||
| void validateMinimumArch(int major, int minor) { | ||
| // Skip checking arch if disabled. | ||
| if (isOptionDisabled(DisableOption::ArchCheck)) { |
Collaborator
There was a problem hiding this comment.
Is this option still used?
Collaborator
Author
There was a problem hiding this comment.
Yes, in executor_utils.cpp getCompiledKernel, there is a
TORCH_CHECK(
!isOptionDisabled(DisableOption::ArchCheck),
"NVFuser Compile: arch check disabled, should not return any compiled kernel");don't think this makes much sense either.... Let me remove it.
Collaborator
Author
|
!build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think these checks make sense. I don't see any reason for disallow lowering of an Ampere kernel on Volta, or on a machine without GPU. Cross compilation support is common for compilers, for example, nvcc has
-archto specify the target architecture, even if your machine has no GPU at all.This is blocking #155, because the bank conflict checking test fails on Volta. I don't think these failure makes sense.