Skip to content

Hopper Mma tests without BroadcastOp#1736

Merged
zasdfgbnm merged 19 commits intomainfrom
matmul-nobroadcast-mma-hopper
Feb 20, 2024
Merged

Hopper Mma tests without BroadcastOp#1736
zasdfgbnm merged 19 commits intomainfrom
matmul-nobroadcast-mma-hopper

Conversation

@zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Feb 7, 2024

Fixes #1628

@zasdfgbnm zasdfgbnm changed the base branch from main to less-mma-test February 7, 2024 04:40
@zasdfgbnm zasdfgbnm changed the title Matmul nobroadcast mma hopper Hopper Mma tests without BroadcastOp Feb 7, 2024
Base automatically changed from less-mma-test to main February 8, 2024 23:55
@zasdfgbnm
Copy link
Collaborator Author

!build

@zasdfgbnm zasdfgbnm requested a review from drzejan2 February 19, 2024 09:44
@zasdfgbnm zasdfgbnm marked this pull request as ready for review February 19, 2024 09:44
Copy link
Contributor

@drzejan2 drzejan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - thank you for simplifying the mma tests for Hopper and exposing helpers so we can reuse them in tests.

@zasdfgbnm
Copy link
Collaborator Author

Internal test failure seems to be unrelated

@zasdfgbnm zasdfgbnm merged commit 46a6850 into main Feb 20, 2024
@zasdfgbnm zasdfgbnm deleted the matmul-nobroadcast-mma-hopper branch February 20, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra S->S copy introduced by tmaLoad->broadcast->mma.

2 participants