Conversation
Priya2698
force-pushed
the
pm/merge_allocationtypes
branch
from
ffe5133 to
f8f5a89
Compare
wujingyue
reviewed
Feb 14, 2024
Collaborator
wujingyue
left a comment
wujingyue
left a comment
There was a problem hiding this comment.
Nice! LGTM with comments
Collaborator
Author
|
Converting to draft until PR #1743 is patched. |
Priya2698
force-pushed
the
pm/merge_allocationtypes
branch
from
74a30e3 to
fda29d2
Compare
Priya2698
changed the title
AllocationType and unify PointerArithmetic, Evaluate logicAllocationType
wujingyue
approved these changes
Mar 1, 2024
Collaborator
|
!build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the
AllocationTypes:NoAlias->NewInplaceUpdate->ReuseBuffer3.PointerArithmeticandEvaluate->EvaluateLogic for. This was done in PR #1775PointerArithmeticandEvaluateis merged which removes additional code (markOutputForEvaluation) used for adding outputs of typeEvaluatein PR #1743.