Conversation
Collaborator
Author
|
!build |
zasdfgbnm
reviewed
Mar 13, 2024
zasdfgbnm
reviewed
Mar 13, 2024
zasdfgbnm
reviewed
Mar 13, 2024
zasdfgbnm
reviewed
Mar 13, 2024
wujingyue
reviewed
Mar 13, 2024
csrc/expr_evaluator.h
Outdated
| @@ -59,6 +59,11 @@ class ExpressionEvaluator { | |||
| //! Try to evaluate a value using const evaluator ref | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| //! Try to evaluate a value using const evaluator ref | |
| //! Try to evaluate a value without using known_values_. |
| const ExpressionEvaluator& ee, | ||
| const std::vector<PolymorphicValue>& inputs) const; | ||
|
|
||
| virtual std::vector<PolymorphicValue> evaluate( |
Collaborator
There was a problem hiding this comment.
There should be a code comment here about why this version of evaluate (and thus the added complexity) is needed and how it's different from the version above.
Collaborator
Author
There was a problem hiding this comment.
Added. Should be more clear now.
Collaborator
There was a problem hiding this comment.
Can you fix the format of the comment? It shows some unnecessary indentation.
Collaborator
Author
|
!build |
wujingyue
approved these changes
Mar 14, 2024
| const ExpressionEvaluator& ee, | ||
| const std::vector<PolymorphicValue>& inputs) const; | ||
|
|
||
| virtual std::vector<PolymorphicValue> evaluate( |
Collaborator
There was a problem hiding this comment.
Can you fix the format of the comment? It shows some unnecessary indentation.
Collaborator
Author
|
!build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to add support for evaluating multiple ops together and skip evaluating intermediate inputs.
Current use cases:
MmaOp + Cast,MmaOp + Bias + Castin a single call instead of one op at a time.