Conversation
Collaborator
Author
|
!build |
Collaborator
Author
|
!build |
jacobhinkle
reviewed
Mar 15, 2024
| ((double)bytesProcessed() / ((double)kernel_time_ms_ / 1000)) / | ||
| (double)1.0e9; | ||
| debug() << "kernel" << kernel_id_ << " run in " << kernel_time_ms_ | ||
| << " ms, achieved: " << gb_per_s << " GB/s" << std::endl; |
Collaborator
There was a problem hiding this comment.
This change means that we print bytes processed even when we do not execute the kernel, correct?
Collaborator
Author
There was a problem hiding this comment.
Correct -- I do see gb_per_s=inf printed, which is the right answer.
I believe this will change again with #1930. This printing will have to be skipped because kernel_id_ won't even exist.
Collaborator
Author
|
!build |
Collaborator
Author
|
!build |
1 similar comment
Collaborator
Author
|
!build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execute_kernel_, but is read (e.g.) even when the kernel is not executed. So I hoistedoutputBytesProcessedout ofif execute_kernel_.Fixes #1943.