Drain cp.async jobs after main loop#2008
Merged
jacobhinkle merged 2 commits intomainfrom Mar 28, 2024
Merged
Conversation
This is an alternative to #2005
Collaborator
Author
|
!build --diff-bench |
zasdfgbnm
approved these changes
Mar 27, 2024
Collaborator
Author
|
Fixed binary test. Python test is complex div correctness (unrelated). Code diffs look normal. I'm not sure why codediff 1/5 failed to upload but the artifact has a normal looking html. I'll merge once clang-build passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just places a
cp.async.wait_group 0instruction immediately after any circular buffer main loop which is the approach taken by CUTLASS for pipelining GEMMs: (see mma_multistage.h#L664-L665). The previous fix for #2000, #2001, is reverted.This is an alternative to #2005.
Fixes #2000