Conversation
Collaborator
Author
|
!build --dist |
Collaborator
|
Can you please explain the motivation for this change? |
samnordmann
reviewed
Apr 29, 2024
samnordmann
reviewed
Apr 29, 2024
Collaborator
Author
@xwang233 talked about this in the nvFuser-MultiGPU chatroom. At this moment, there isn't much value to support non-distributed build of pytorch. The cost of additional CI and knobs like NVFUSER_DISTRIBUTED/USE_DISTRIBUTED just for that config isn't worthwhile. |
Collaborator
Author
|
!build |
Collaborator
Author
|
!build --dist |
wujingyue
commented
Apr 29, 2024
Collaborator
Author
|
!build --dist |
Collaborator
Author
|
Glad that CI has recovered, making this PR ready to review again. PTAL |
xwang233
approved these changes
Apr 30, 2024
Collaborator
xwang233
left a comment
xwang233
left a comment
There was a problem hiding this comment.
LGTM. Thanks for working on this.
zasdfgbnm
pushed a commit
that referenced
this pull request
May 2, 2024
@xwang233 discussed this in the nvFuser-MultiGPU chatroom. At this moment, supporting non-distributed build of pytorch isn't worth the cost of additional CI and using knobs like `NVFUSER_DISTRIBUTED` or `USE_DISTRIBUTED`. Feel free to revert this PR if non-distributed build becomes important.
Aidyn-A
added a commit
to Aidyn-A/Fuser
that referenced
this pull request
May 6, 2024
This reverts commit 6e05931.
wujingyue
pushed a commit
that referenced
this pull request
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@xwang233 discussed this in the nvFuser-MultiGPU chatroom. At this moment, supporting non-distributed build of pytorch isn't worth the cost of additional CI and using knobs like
NVFUSER_DISTRIBUTEDorUSE_DISTRIBUTED.This PR reverts #1711
Feel free to revert this PR if non-distributed build becomes important.