Merged
Conversation
Collaborator
Author
|
!build |
Collaborator
Author
|
!build |
naoyam
commented
May 10, 2024
Collaborator
Author
There was a problem hiding this comment.
Almost exact copy from id_model.cpp
naoyam
commented
May 10, 2024
| idGraph(IdMappingMode::LOOP).validateConsistency(); | ||
| } | ||
|
|
||
| std::unordered_map<ValGroup, IterDomain*> IdModel::buildLoopPromotionMap( |
Collaborator
Author
There was a problem hiding this comment.
Moved to loop_promotion.cpp
Collaborator
Author
|
CI passed at 2b605cd |
Collaborator
Author
|
!build |
zasdfgbnm
approved these changes
May 20, 2024
Collaborator
zasdfgbnm
left a comment
zasdfgbnm
left a comment
There was a problem hiding this comment.
Is the callback only used in tests? Or it will be used somewhere else in the future?
Collaborator
Author
|
Only the tests. I don't have any planned use case either. |
naoyam
added a commit
that referenced
this pull request
May 21, 2024
This was a small oversight. Since sibling tensors always share the loops, their iter domains should always be mapped in the loop graph, no matter how they are inlined. Added a simple repro and a fix. (Stacked on top of #2232)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No logic change. Mostly mechanical cleanup.
Replaced the test-specific IdModel subclass with a callback interface. The callback interface allows to save all necessary temporary results for validation. No more duplication of
buildLoopPromotionMap. (Related comment: #2220 (comment))To introduce the callback interface, moved the loop promotion part out of
IdModelto its own builder class.