Closed
Conversation
naoyam
added a commit
that referenced
this pull request
May 20, 2024
(Extracted from #2238) Traversal for finding the shortest path from ValGroups to another ValGroups. The algorithm is based on the standard BFS traversal, however, since ValGraph is not an undirected graph, the dependencies of ValGroups and ExprGroups need to be satisfied. Specifically, when visiting an ExprGroup, either its inputs or outputs must be visited before. Similarly, when visiting a ValGroup, there must be at least one defining ExprGroup or one use ExprGroup that is already visited. The main use case is tensor indexing (#2238), where a typical traversal would be from loop domains to allocation domains. Some indexing-specific specialization would be needed, for example, dependencies with broadcast domains can be ignored as their index is always just zero. The indexing shortest-path traversal would be implemented by subclassing this class. Please see the new unit tests for concrete examples.
Collaborator
Author
|
!test |
Collaborator
Author
|
!test |
1 similar comment
Collaborator
Author
|
!test |
Collaborator
Author
|
!test |
1 similar comment
Collaborator
Author
|
!test |
Collaborator
Author
|
!test --diff |
Collaborator
Author
|
!test |
Collaborator
Author
|
!test |
Collaborator
Author
|
!test |
Collaborator
Author
|
!test |
Collaborator
Author
|
!test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Rebased #2218)