Skip to content

Fix bug in scatter #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wujingyue merged 2 commits into from
May 15, 2024
Merged

Fix bug in scatter #2245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a559b5c
fix bug in scatter
samnordmann May 14, 2024
bc50c2b
lintrunner
samnordmann May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion csrc/multidevice/communication.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,8 @@ c10::intrusive_ptr<c10d::Work> postScatter(
input_tensors.front().push_back(output_tensor);
continue;
}
input_tensors.front().push_back(input_tensor.slice(0, j, j + 1));
input_tensors.front().push_back(
input_tensor.slice(0, j, j + 1).contiguous());
j++;
}

Expand Down
5 changes: 3 additions & 2 deletions tests/cpp/test_multidevice_pipeline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,9 @@ DeviceMesh mesh1({1});
DeviceMesh mesh2({0, 1, 2, 3});
DeviceMesh mesh3({0, 2, 3});
DeviceMesh mesh4({1, 0, 2});
auto all_meshes = testing::Values(mesh0, mesh1, mesh2, mesh3, mesh4);
auto all_nontrivial_meshes = testing::Values(mesh2, mesh3, mesh4);
DeviceMesh mesh5({1, 0});
auto all_meshes = testing::Values(mesh0, mesh1, mesh2, mesh3, mesh4, mesh5);
auto all_nontrivial_meshes = testing::Values(mesh2, mesh3, mesh4, mesh5);

} // namespace

Expand Down