Remove CommParams and make the fields there data attributes.#2256
Merged
Remove CommParams and make the fields there data attributes.#2256
Conversation
wujingyue
commented
May 15, 2024
| Team team_; | ||
| }; | ||
|
|
||
| // The method "post" triggers the execution of the communication. This call is |
Collaborator
Author
There was a problem hiding this comment.
Note: I moved this comment to postSingleCommunication, because Communication::post is no longer a thing.
Collaborator
Author
|
!build --dist |
Collaborator
|
!build --dist |
samnordmann
approved these changes
May 16, 2024
Collaborator
samnordmann
left a comment
samnordmann
left a comment
There was a problem hiding this comment.
LGTM! Thanks, this makes Communication IRs cleaner
wujingyue
force-pushed
the
wjy/underscore
branch
4 times, most recently
from
48680ed to
53cc014
Compare
Collaborator
Author
|
!build |
zasdfgbnm
pushed a commit
that referenced
this pull request
Jun 5, 2024
I initially intended to just make CommParams a data attribute. Then I realized the extra indirection of CommParams doesn't seem to give much practical value after various cleanups we've done, so I flattened CommParams as well and that saved a bit of typing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I initially intended to just make CommParams a data attribute. Then I realized the extra indirection of CommParams doesn't seem to give much practical value after various cleanups we've done, so I flattened CommParams as well and that saved a bit of typing.